Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(api): add e2e for auth utils fix for handling null values in group auth rule #2543

Merged
merged 3 commits into from May 14, 2024

Conversation

sundersc
Copy link
Contributor

Description of changes

Add E2E tests to verify auth utils fix for handling null values in group claim.

When a model contains an owner rule and groups rule, auth utils were wrongly throwing unauthorized error when groups field is null but owner value is valid. AppSync recently fixes this issue in the service.

This PR adds E2E test to API repo to confirm that fix.

CDK / CloudFormation Parameters Changed

NA

Issue #, if available

NA

Description of how you validated changes

  • E2E tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner May 10, 2024 05:29
@sundersc sundersc merged commit 1eaa52a into aws-amplify:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants