Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): handle attribute type change on gsi #2542

Merged
merged 4 commits into from May 15, 2024

Conversation

sundersc
Copy link
Contributor

@sundersc sundersc commented May 9, 2024

Description of changes

Fix the bug: Attribute type changes are not reflected in amplify managed tables.

To resolve this, we will delete all the indexes referencing the attribute with type changes and recreate them.

CDK / CloudFormation Parameters Changed

NA

Issue #, if available

NA

Description of how you validated changes

  • Manual test
  • New E2E test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sundersc sundersc requested a review from a team as a code owner May 9, 2024 20:30
@sundersc sundersc force-pushed the amp-table-attribute-change branch from 43cbb3d to d7334fc Compare May 9, 2024 20:32
palpatim
palpatim previously approved these changes May 9, 2024
@sundersc sundersc force-pushed the amp-table-attribute-change branch from f5c3260 to e6b7438 Compare May 13, 2024 19:10
@sundersc sundersc merged commit f0a4709 into main May 15, 2024
2 of 7 checks passed
@sundersc sundersc deleted the amp-table-attribute-change branch May 15, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants