ci: add deprecate release workflow #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palpatim
reviewed
May 9, 2024
scripts/components/git_client.ts
Outdated
| */ | ||
| getTagsAtCommit = async (commitHash: string) => { | ||
| // filter out packages not published to npm | ||
| const privatePackages = [ |
There was a problem hiding this comment.
Not a blocker, but how can we keep this list in sync? How do we remember in the future to edit this list if we add a private package?
There was a problem hiding this comment.
I've created a postinstall command to generate the list of private packages so now it should always be in sync.
| * Note that this does not mean just looking up the previous release tags. | ||
| * It may be the case that package-A was released in release-5 but the previous release of package-A happened in release-2. | ||
| * This method will walk through past release tags until it finds the previous version of all of the input package versions | ||
| * If a previous version of some package cannot be found, an error is thrown. |
There was a problem hiding this comment.
DOes this mean that we are unable to roll back releases that contain the first public publication of a package?
There was a problem hiding this comment.
Yes, I'll see if there is a way to resolve this.
There was a problem hiding this comment.
I've changed this to just print a warning message when a previous release is not found.
palpatim
approved these changes
May 14, 2024
phani-srikar
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Usage
Example:
This will deprecate all packages that were bumped in 143a266. If the deprecated version is also the latest, the workflow will also set the latest tag for all of these packages to the previous version.
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
I ran the workflow against the CodeBuild project in my personal account. I only tested against the verdaccio local registry so the production deprecation is not fully tested.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.