Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cdk to 2.129.0 #2529

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

phani-srikar
Copy link
Contributor

Description of changes

Upgrading the CDK library version to 2.129.0 which vends the upgraded Node 18 runtimes for the Lambda functions. This is necessary because:

We are ending support for Node.js 16 in Lambda on June 12, 2024. This follows Node.js 16 End-Of-Life (EOL) reached on September 11, 2023 [1]

This version is chosen so to be the target based on our testing and ease to upgrade without running into any complex breaking changes.

This PR should be released after aws-amplify/amplify-cli#13757

CDK / CloudFormation Parameters Changed

Issue #, if available

Description of how you validated changes

  • We first upgraded the CDK dependency in the API plugin repository and published a tag acdk-upgrade-2-129. Link to branch
  • We've upgraded the CDK dependency in CLI repo in the guest/data/upgrade-cdk-2.129.0 feature branch.
  • We've created a tagged-release-without-e2e-tests/acdk-upgrade-2-129 branch in CLI that consumes the upgraded API plugin via acdk-upgrade-2-129 tag and then published a CLI tag also with the same name.
  • We've run full E2E on tagged-release-without-e2e-tests/acdk-upgrade-2-129 branch in CLI. Link to run
  • We've then consumed the acdk-upgrade-2-129 tag of upgraded CLI in API repo and run full E2E suite there. Link to run.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant