enforce consistent type imports and exports

[josefaidt]

Problem

follow-up to #709

Enforces consistent type imports and exports. This can help prevent errors such as https://typescript.tv/errors/#ts2742 when consuming the libraries with pnpm or npm's "linked" install strategy.

• enables https://typescript-eslint.io/rules/consistent-type-imports
• enables https://typescript-eslint.io/rules/consistent-type-exports
• enables https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/consistent-type-specifier-style.md
• extends https://github.com/import-js/eslint-plugin-import/blob/main/config/recommended.js
• extends https://github.com/import-js/eslint-plugin-import/blob/main/config/typescript.js

Enabling this emits 504 errors from ESLint

✖ 504 problems (504 errors, 0 warnings)
  504 errors and 0 warnings potentially fixable with the `--fix` option.

Questions:

• how do we feel about the inline type imports? This adheres to "no duplicate imports", but can be rough to sort properly with ESLint (it's easier to sort import type)
• any thoughts on enforcing import order? https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/order.md#options

Issue number, if available:

Changes

Corresponding docs PR, if applicable:

Validation

Checklist

• If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
• If this PR requires a change to the Project Architecture README, I have included that update in this PR.
• If this PR requires a docs update, I have linked to that docs PR above.
• If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0843268

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[edwardfoyle]

This PR needs to also include fixing the newly introduced lint errors

[josefaidt]

will revisit this later, closing