Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move to using the Maven Publish DSL #2815

Merged
merged 4 commits into from May 15, 2024
Merged

Conversation

mattcreaser
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Migrated publishing to use the publishing DSL. This is a pre-requisite to upgrading to Gradle 8+.

The publishing DSL adds scope information and publishes Gradle metadata by default. Although those are beneficial, they could potentially impact customers and should not be added in a minor version, so I've disabled/removed both of those. They can be enabled in a future major version release.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner May 10, 2024 17:57
@mattcreaser
Copy link
Contributor Author

Note: the one difference I've noted with this PR is that it adds the Kotlin standard library as a dependency to all poms, specifically
<artifactId>kotlin-stdlib-jdk8</artifactId>.

I am not actually sure why it wasn't being added before since the Kotlin plugin adds it to all projects so it always has been a dependency. Looking into whether there is any problem here.

@mattcreaser
Copy link
Contributor Author

After some additional testing I don't believe there is any downside to this additional dependency being added. If app is running on JDK < 26 it does not add a requirement for desugaring unless we invoke one of the JDK8 APIs, which already would have been requiring desugaring previously.

@mattcreaser mattcreaser enabled auto-merge (squash) May 14, 2024 16:56
@mattcreaser mattcreaser merged commit bded3bc into main May 15, 2024
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/maven-publish branch May 15, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants