Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): Add code coverage thresholds #2582

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mattcreaser
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Added coverage thresholds to codecov.yml

How did you test these changes?

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner September 7, 2023 21:51
@codecov-commenter
Copy link

Codecov Report

Merging #2582 (c0a234a) into main (2298d7f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2582      +/-   ##
==========================================
- Coverage   41.25%   41.24%   -0.01%     
==========================================
  Files         885      885              
  Lines       28237    28237              
  Branches     3993     3993              
==========================================
- Hits        11649    11647       -2     
- Misses      15305    15308       +3     
+ Partials     1283     1282       -1     

📢 Have feedback on the report? Share it here.

@@ -2,11 +2,13 @@ coverage:
status:
project:
default:
informational: true
target: auto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does auto here mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target is the minimum allowed coverage. Value of auto means it's the coverage of the branch you're merging into. Alternatively you can put a percentage value to have an absolute value instead.

https://docs.codecov.com/docs/commit-status#target

@mattcreaser mattcreaser enabled auto-merge (squash) January 26, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants