Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unignore storage and pinpoint tests #2156

Merged
merged 4 commits into from Dec 7, 2022
Merged

Unignore storage and pinpoint tests #2156

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdd3a9a
unignore tests
dengdan154 Dec 5, 2022
217bb79
extend timeout to 60s
dengdan154 Dec 5, 2022
a08344e
Merge branch 'main' into dengdan
dengdan154 Dec 5, 2022
b0dcb5a
Merge branch 'main' into dengdan
sdhuka Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...Test/java/com/amplifyframework/analytics/pinpoint/PinpointAnalyticsInstrumentationTest.kt
View file
Open in desktop
Expand Up @@ -45,7 +45,6 @@ import org.json.JSONException
import org.junit.Assert
import org.junit.Before
import org.junit.BeforeClass
import org.junit.Ignore
import org.junit.Test

class PinpointAnalyticsInstrumentationTest {
Expand Down Expand Up @@ -244,7 +243,6 @@ class PinpointAnalyticsInstrumentationTest {
* an [EndpointProfile] on the [PinpointClient], containing
* all provided Amplify attributes.
*/
@Ignore("Test Failure")
@Test
fun testIdentifyUserWithDefaultProfile() {
val location = testLocation
Expand Down
8 changes: 1 addition & 7 deletions ...age-s3/src/androidTest/java/com/amplifyframework/storage/s3/AWSS3StorageDownloadTest.java
View file
Open in desktop
Expand Up @@ -42,7 +42,6 @@
import org.junit.After;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;

import java.io.File;
Expand All @@ -60,7 +59,7 @@
* Instrumentation test for operational work on download.
*/
public final class AWSS3StorageDownloadTest {
private static final long EXTENDED_TIMEOUT_MS = TimeUnit.SECONDS.toMillis(20);
private static final long EXTENDED_TIMEOUT_MS = TimeUnit.SECONDS.toMillis(60);

private static final StorageAccessLevel TESTING_ACCESS_LEVEL = StorageAccessLevel.PUBLIC;
private static final long LARGE_FILE_SIZE = 10 * 1024 * 1024L; // 10 MB
Expand Down Expand Up @@ -146,7 +145,6 @@ public void tearDown() {
*
* @throws Exception if download fails
*/
@Ignore("Test Failure")
@Test
public void testDownloadSmallFile() throws Exception {
synchronousStorage.downloadFile(SMALL_FILE_NAME, downloadFile, options);
Expand All @@ -158,7 +156,6 @@ public void testDownloadSmallFile() throws Exception {
*
* @throws Exception if download fails
*/
@Ignore("Test Failure")
@Test
public void testDownloadLargeFile() throws Exception {
synchronousStorage.downloadFile(LARGE_FILE_NAME, downloadFile, options, EXTENDED_TIMEOUT_MS);
Expand All @@ -173,7 +170,6 @@ public void testDownloadLargeFile() throws Exception {
* before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testDownloadFileIsCancelable() throws Exception {
final CountDownLatch canceled = new CountDownLatch(1);
Expand Down Expand Up @@ -220,7 +216,6 @@ public void testDownloadFileIsCancelable() throws Exception {
* completed successfully before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testDownloadFileIsResumable() throws Exception {
final CountDownLatch completed = new CountDownLatch(1);
Expand Down Expand Up @@ -271,7 +266,6 @@ public void testDownloadFileIsResumable() throws Exception {
* completed successfully before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testGetTransferOnPause() throws Exception {
final CountDownLatch completed = new CountDownLatch(1);
Expand Down
7 changes: 1 addition & 6 deletions ...orage-s3/src/androidTest/java/com/amplifyframework/storage/s3/AWSS3StorageUploadTest.java
View file
Open in desktop
Expand Up @@ -42,7 +42,6 @@
import org.junit.After;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;

import java.io.File;
Expand All @@ -61,7 +60,7 @@
* Instrumentation test for operational work on upload.
*/
public final class AWSS3StorageUploadTest {
private static final long EXTENDED_TIMEOUT_MS = TimeUnit.SECONDS.toMillis(20);
private static final long EXTENDED_TIMEOUT_MS = TimeUnit.SECONDS.toMillis(60);

private static final StorageAccessLevel TESTING_ACCESS_LEVEL = StorageAccessLevel.PUBLIC;
private static final long LARGE_FILE_SIZE = 10 * 1024 * 1024L; // 10 MB
Expand Down Expand Up @@ -146,7 +145,6 @@ public void testUploadSmallFileStream() throws Exception {
*
* @throws Exception if upload fails
*/
@Ignore("Test Failure")
@Test
public void testUploadLargeFile() throws Exception {
File uploadFile = new RandomTempFile(LARGE_FILE_SIZE);
Expand Down Expand Up @@ -211,7 +209,6 @@ public void testUploadFileIsCancelable() throws Exception {
* completed successfully before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testUploadFileIsResumable() throws Exception {
final CountDownLatch completed = new CountDownLatch(1);
Expand Down Expand Up @@ -264,7 +261,6 @@ public void testUploadFileIsResumable() throws Exception {
* completed successfully before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testUploadFileGetTransferOnPause() throws Exception {
final CountDownLatch completed = new CountDownLatch(1);
Expand Down Expand Up @@ -327,7 +323,6 @@ public void testUploadFileGetTransferOnPause() throws Exception {
* completed successfully before timeout
*/
@SuppressWarnings("unchecked")
@Ignore("Test Failure")
@Test
public void testUploadInputStreamGetTransferOnPause() throws Exception {
final CountDownLatch completed = new CountDownLatch(1);
Expand Down