Custom action while await #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tko007
changed the title
|
@tko007 Thanks for the PR (and sorry for the long delay). While I see the usefulness of these functions I'm a bit hesitant to add them to the library. These are functions that are quite easy to roll yourself and you might already be using another FP library such as Vavr which allows for easier function composition and you may want to leverage that instead. It just seems to me that this is beyond the scope of Awaitility... WDYT? |
|
@johanhaleby @tko007 Although I tried to create a builder for this, I agree with Johan in this topic. See also our discussion in #136. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created in the first draft a class to collect all these possible building blocks, and placed in the core awaitility module. In java the usage will be .until(andThen(func1, func2))