Create ConditionAwaiter via factory #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Out of curiosity, what is the use case you're trying to solve? Why do you need different implementations of |
|
Basically alot of tests fail because the server load increases the execution time. So i'm trying to create a load based "grace period" so the tests can take longer then the maximum time when the load is too high. |
|
Love to see this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConditionAwaiter is now created via factory
Factory can be replaced with system-property "awaitility-condition-awaiter-factory".
These changes allow the ConditionAwaiter to be easily replaced. This makes it possible for the CI-environment to use a different ConditionAwaiter logic than the DEV-environment.
The custom factory needs extend ConditionAwaiterFactory and implement newConditionAwaiter.
To replace the factory set --awaitility-condition-awaiter-factory to "org.path.to.ClassName".