fix: Manual typings with generics #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The file is generated by typescript, so I don't think this is ideal because it'd be undone. npx -p typescript tsc src/*.js --declaration --allowJs --emitDeclarationOnly --outDir . |
|
it never changes, does it? for next major version we can code up one manually i'm sure :) I propose to remove the generation as it does more harm than good in this instance. |
|
This is 9.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 9.x release we lost some accuracy in types.
compared to 8.x series https://github.com/avoidwork/tiny-lru/blob/8.0.2/tiny-lru.d.ts