Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipath: Optimization method for obtaining multipath states #5893

Closed
wants to merge 2 commits into from

Conversation

ut003460
Copy link
Contributor

  1. Early return: When a matching path is found, the result can be returned immediately without continuing to traverse other paths. This can improve efficiency.
  2. Use a dictionary to store path information: Path information can be stored in the dictionary with the path as the key, which can quickly find the corresponding path's status information.
  3. Exception handling: Add appropriate exception handling to deal with situations where a matching path is not found

1. Early return: When a matching path is found, the result can be returned immediately without continuing to traverse other paths. This can improve efficiency.
2. Use a dictionary to store path information: Path information can be stored in the dictionary with the path as the key, which can quickly find the corresponding path's status information.
3. Exception handling: Add appropriate exception handling to deal with situations where a matching path is not found

Signed-off-by: ut003460 <xiongneng@uniontech.com>
Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ut003460, thank you for your contribution, but can you provide more information of what you want to achieve here? I am little confused from your commit message.

  1. Early return: When a matching path is found, the result can be returned immediately without continuing to traverse other paths. This can improve efficiency.

Your changes actually removes the early return.

  1. Use a dictionary to store path information: Path information can be stored in the dictionary with the path as the key, which can quickly find the corresponding path's status information.

If we use early return, we don't need to store anything.

  1. Exception handling: Add appropriate exception handling to deal with situations where a matching path is not found

Your changes completely lacks Exception handling.

@Naresh-ibm
Copy link
Contributor

@ut003460 I feel the same like @richtja.
your actually removing the early return.
and not require to store anything here. please re-check and elaborate your claim.

@ut003460 ut003460 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 105
Development

Successfully merging this pull request may close these issues.

None yet

3 participants