Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow the remote dotfiles to be fetched from a branch. #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: allow the remote dotfiles to be fetched from a branch. #4

wants to merge 5 commits into from

Conversation

shamangeorge
Copy link
Member

@shamangeorge shamangeorge commented May 20, 2021 •
edited

Want to be able to specify a branch when we are fetching

Tim Ioannidis and others added 3 commits May 10, 2021 16:21
@shamangeorge shamangeorge requested a review from chemeng May 20, 2021 16:49
chemeng
chemeng reviewed May 20, 2021
View reviewed changes
Copy link

@chemeng chemeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing the parsing of the dotfiles_branch argument I assume. We probably don't need the constant GITHUB_DOTFILES_REPOSITORY_BRANCH then since you can simply specify default master in the commandline arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemeng chemeng chemeng left review comments

Assignees

@shamangeorge shamangeorge

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shamangeorge @chemeng