Support ESLint 8.x #336
Merged
Support ESLint 8.x #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/ci.yml
sindresorhus
approved these changes
Oct 20, 2021
| - uses: codecov/codecov-action@v2 | ||
| # `xo` can't work on ESLint 8 and Node.js 16 yet | ||
| - if: ${{ matrix.node-version == '^14.17' }} | ||
| run: npm install eslint@7 && npx xo |
There was a problem hiding this comment.
Why does XO fail if the package has ESLint 8 installed?
There was a problem hiding this comment.
Because eslint-plugin-unicorn in xo don't support eslint 8, we can fix it by adding eslint-plugin-unicorn to dependencies, but I don't think it's necessary, because xo is blocking by eslint-plugin-ava, we'll get new xo very soon.
There was a problem hiding this comment.
How strange; I get it with npm 8 and it seems to be some resolution error. It's weird because you'd think the dependencies are scoped within the package. But fine, please do circle back when it's all done.
|
@fisker @sindresorhus is this a breaking change or a minor release? |
|
Minor. |
|
Published as 13.1. |
81 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #335