Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests feedback, linked to #104 #105

Merged
merged 1 commit into from Jun 7, 2016
Merged

Improve tests feedback, linked to #104 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -75,6 +75,7 @@
"ava": "*",
"coveralls": "^2.11.9",
"eslint": "^2.2.0",
"eslint-ava-rule-tester": "^0.1.1",
"js-combinatorics": "^0.5.0",
"nyc": "^6.4.0",
"pify": "^2.3.0",
Expand Down
346 changes: 172 additions & 174 deletions test/assertion-arguments.js
View file
Open in desktop

Large diffs are not rendered by default.

170 changes: 84 additions & 86 deletions test/assertion-message.js
View file
Open in desktop
@@ -1,8 +1,8 @@
import test from 'ava';
import {RuleTester} from 'eslint';
import avaRuleTester from 'eslint-ava-rule-tester';
import rule from '../rules/assertion-message';

const ruleTester = new RuleTester({
const ruleTester = avaRuleTester(test, {
env: {
es6: true
}
Expand Down Expand Up @@ -34,90 +34,88 @@ function testCase(option, content, errors, useHeader) {
};
}

test(() => {
ruleTester.run('assertion-message', rule, {
valid: [
testCase('always', `t.pass('message');`),
testCase('always', `t.fail('message');`),
testCase('always', `t.truthy('unicorn', 'message');`),
testCase('always', `t.falsy('unicorn', 'message');`),
testCase('always', `t.true(true, 'message');`),
testCase('always', `t.false(false, 'message');`),
testCase('always', `t.is('same', 'same', 'message');`),
testCase('always', `t.not('not', 'same', 'message');`),
testCase('always', `t.deepEqual({}, {}, 'message');`),
testCase('always', `t.notDeepEqual({}, {a: true}, 'message');`),
testCase('always', `t.throws(Promise.reject(), 'message');`),
testCase('always', `t.notThrows(Promise.resolve(), 'message');`),
testCase('always', `t.regex(a, /a/, 'message');`),
testCase('always', `t.notRegex(a, /a/, 'message');`),
testCase('always', `t.ifError(new Error(), 'message');`),
testCase('always', `t.skip.is('same', 'same', 'message');`),
testCase('always', `t.is.skip('same', 'same', 'message');`),
testCase('always', `t.plan('a', 'b', 'c', 'd', 'message');`),
testCase('always', `t.end('a', 'b', 'c', 'd', 'message');`),
// shouldn't be triggered since it's not a test file
testCase('always', `t.true(true);`, [], false),
ruleTester.run('assertion-message', rule, {
valid: [
testCase('always', `t.pass('message');`),
testCase('always', `t.fail('message');`),
testCase('always', `t.truthy('unicorn', 'message');`),
testCase('always', `t.falsy('unicorn', 'message');`),
testCase('always', `t.true(true, 'message');`),
testCase('always', `t.false(false, 'message');`),
testCase('always', `t.is('same', 'same', 'message');`),
testCase('always', `t.not('not', 'same', 'message');`),
testCase('always', `t.deepEqual({}, {}, 'message');`),
testCase('always', `t.notDeepEqual({}, {a: true}, 'message');`),
testCase('always', `t.throws(Promise.reject(), 'message');`),
testCase('always', `t.notThrows(Promise.resolve(), 'message');`),
testCase('always', `t.regex(a, /a/, 'message');`),
testCase('always', `t.notRegex(a, /a/, 'message');`),
testCase('always', `t.ifError(new Error(), 'message');`),
testCase('always', `t.skip.is('same', 'same', 'message');`),
testCase('always', `t.is.skip('same', 'same', 'message');`),
testCase('always', `t.plan('a', 'b', 'c', 'd', 'message');`),
testCase('always', `t.end('a', 'b', 'c', 'd', 'message');`),
// shouldn't be triggered since it's not a test file
testCase('always', `t.true(true);`, [], false),

testCase('never', `t.pass();`),
testCase('never', `t.fail();`),
testCase('never', `t.truthy('unicorn');`),
testCase('never', `t.falsy('unicorn');`),
testCase('never', `t.true(true);`),
testCase('never', `t.false(false);`),
testCase('never', `t.is('same', 'same');`),
testCase('never', `t.not('not', 'same');`),
testCase('never', `t.deepEqual({}, {});`),
testCase('never', `t.notDeepEqual({}, {a: true});`),
testCase('never', `t.throws(Promise.reject());`),
testCase('never', `t.notThrows(Promise.resolve());`),
testCase('never', `t.regex(a, /a/);`),
testCase('never', `t.notRegex(a, /a/);`),
testCase('never', `t.ifError(new Error());`),
testCase('never', `t.skip.is('same', 'same');`),
testCase('never', `t.is.skip('same', 'same');`),
testCase('never', `t.plan('a', 'b', 'c', 'd');`),
testCase('never', `t.end('a', 'b', 'c', 'd');`),
// shouldn't be triggered since it's not a test file
testCase('never', `t.true(true, 'message');`, [], false)
],
invalid: [
testCase('always', `t.pass();`, missingError),
testCase('always', `t.fail();`, missingError),
testCase('always', `t.truthy('unicorn');`, missingError),
testCase('always', `t.falsy('unicorn');`, missingError),
testCase('always', `t.true(true);`, missingError),
testCase('always', `t.false(false);`, missingError),
testCase('always', `t.is('same', 'same');`, missingError),
testCase('always', `t.not('not', 'same');`, missingError),
testCase('always', `t.deepEqual({}, {});`, missingError),
testCase('always', `t.notDeepEqual({}, {a: true});`, missingError),
testCase('always', `t.throws(Promise.reject());`, missingError),
testCase('always', `t.notThrows(Promise.resolve());`, missingError),
testCase('always', `t.regex(a, /a/);`, missingError),
testCase('always', `t.notRegex(a, /a/);`, missingError),
testCase('always', `t.ifError(new Error());`, missingError),
testCase('always', `t.skip.is('same', 'same');`, missingError),
testCase('always', `t.is.skip('same', 'same');`, missingError),
testCase('always', `t.pass();`, missingError),
testCase('never', `t.pass();`),
testCase('never', `t.fail();`),
testCase('never', `t.truthy('unicorn');`),
testCase('never', `t.falsy('unicorn');`),
testCase('never', `t.true(true);`),
testCase('never', `t.false(false);`),
testCase('never', `t.is('same', 'same');`),
testCase('never', `t.not('not', 'same');`),
testCase('never', `t.deepEqual({}, {});`),
testCase('never', `t.notDeepEqual({}, {a: true});`),
testCase('never', `t.throws(Promise.reject());`),
testCase('never', `t.notThrows(Promise.resolve());`),
testCase('never', `t.regex(a, /a/);`),
testCase('never', `t.notRegex(a, /a/);`),
testCase('never', `t.ifError(new Error());`),
testCase('never', `t.skip.is('same', 'same');`),
testCase('never', `t.is.skip('same', 'same');`),
testCase('never', `t.plan('a', 'b', 'c', 'd');`),
testCase('never', `t.end('a', 'b', 'c', 'd');`),
// shouldn't be triggered since it's not a test file
testCase('never', `t.true(true, 'message');`, [], false)
],
invalid: [
testCase('always', `t.pass();`, missingError),
testCase('always', `t.fail();`, missingError),
testCase('always', `t.truthy('unicorn');`, missingError),
testCase('always', `t.falsy('unicorn');`, missingError),
testCase('always', `t.true(true);`, missingError),
testCase('always', `t.false(false);`, missingError),
testCase('always', `t.is('same', 'same');`, missingError),
testCase('always', `t.not('not', 'same');`, missingError),
testCase('always', `t.deepEqual({}, {});`, missingError),
testCase('always', `t.notDeepEqual({}, {a: true});`, missingError),
testCase('always', `t.throws(Promise.reject());`, missingError),
testCase('always', `t.notThrows(Promise.resolve());`, missingError),
testCase('always', `t.regex(a, /a/);`, missingError),
testCase('always', `t.notRegex(a, /a/);`, missingError),
testCase('always', `t.ifError(new Error());`, missingError),
testCase('always', `t.skip.is('same', 'same');`, missingError),
testCase('always', `t.is.skip('same', 'same');`, missingError),
testCase('always', `t.pass();`, missingError),

testCase('never', `t.pass('message');`, foundError),
testCase('never', `t.fail('message');`, foundError),
testCase('never', `t.truthy('unicorn', 'message');`, foundError),
testCase('never', `t.falsy('unicorn', 'message');`, foundError),
testCase('never', `t.true(true, 'message');`, foundError),
testCase('never', `t.false(false, 'message');`, foundError),
testCase('never', `t.is('same', 'same', 'message');`, foundError),
testCase('never', `t.not('not', 'same', 'message');`, foundError),
testCase('never', `t.deepEqual({}, {}, 'message');`, foundError),
testCase('never', `t.notDeepEqual({}, {a: true}, 'message');`, foundError),
testCase('never', `t.throws(Promise.reject(), 'message');`, foundError),
testCase('never', `t.notThrows(Promise.resolve(), 'message');`, foundError),
testCase('never', `t.regex(a, /a/, 'message');`, foundError),
testCase('never', `t.notRegex(a, /a/, 'message');`, foundError),
testCase('never', `t.ifError(new Error(), 'message');`, foundError),
testCase('never', `t.skip.is('same', 'same', 'message');`, foundError),
testCase('never', `t.is.skip('same', 'same', 'message');`, foundError)
]
});
testCase('never', `t.pass('message');`, foundError),
testCase('never', `t.fail('message');`, foundError),
testCase('never', `t.truthy('unicorn', 'message');`, foundError),
testCase('never', `t.falsy('unicorn', 'message');`, foundError),
testCase('never', `t.true(true, 'message');`, foundError),
testCase('never', `t.false(false, 'message');`, foundError),
testCase('never', `t.is('same', 'same', 'message');`, foundError),
testCase('never', `t.not('not', 'same', 'message');`, foundError),
testCase('never', `t.deepEqual({}, {}, 'message');`, foundError),
testCase('never', `t.notDeepEqual({}, {a: true}, 'message');`, foundError),
testCase('never', `t.throws(Promise.reject(), 'message');`, foundError),
testCase('never', `t.notThrows(Promise.resolve(), 'message');`, foundError),
testCase('never', `t.regex(a, /a/, 'message');`, foundError),
testCase('never', `t.notRegex(a, /a/, 'message');`, foundError),
testCase('never', `t.ifError(new Error(), 'message');`, foundError),
testCase('never', `t.skip.is('same', 'same', 'message');`, foundError),
testCase('never', `t.is.skip('same', 'same', 'message');`, foundError)
]
});
120 changes: 59 additions & 61 deletions test/max-asserts.js
View file
Open in desktop
@@ -1,8 +1,8 @@
import test from 'ava';
import {RuleTester} from 'eslint';
import avaRuleTester from 'eslint-ava-rule-tester';
import rule from '../rules/max-asserts';

const ruleTester = new RuleTester({
const ruleTester = avaRuleTester(test, {
env: {
es6: true
}
Expand All @@ -15,65 +15,63 @@ function nbAssertions(n) {
return Array.from({length: n}).map(() => 't.is(1, 1);').join('\n');
}

test(() => {
ruleTester.run('max-asserts', rule, {
valid: [
`${header} test(t => { ${nbAssertions(3)} });`,
`${header}
test(t => { ${nbAssertions(3)} });
ruleTester.run('max-asserts', rule, {
valid: [
`${header} test(t => { ${nbAssertions(3)} });`,
`${header}
test(t => { ${nbAssertions(3)} });
test(t => { ${nbAssertions(3)} });
`,
`${header} test(t => { t.plan(5); ${nbAssertions(5)} });`,
`${header} test(t => { t.is.skip(1, 1); ${nbAssertions(4)} });`,
`${header} test.cb(t => { ${nbAssertions(5)} t.end(); });`,
{
code: `${header} test(t => { ${nbAssertions(3)} });`,
options: [3]
},
{
code: `${header} test(t => { notT.is(1, 1); notT.is(1, 1); notT.is(1, 1); });`,
options: [2]
},
// shouldn't be triggered since it's not a test file
`test(t => { ${nbAssertions(10)} });`
],
invalid: [
{
code: `${header} test(t => { ${nbAssertions(6)} });`,
errors
},
{
code: `${header}
test(t => { ${nbAssertions(3)} });
test(t => { ${nbAssertions(6)} });
`,
`${header} test(t => { t.plan(5); ${nbAssertions(5)} });`,
`${header} test(t => { t.is.skip(1, 1); ${nbAssertions(4)} });`,
`${header} test.cb(t => { ${nbAssertions(5)} t.end(); });`,
{
code: `${header} test(t => { ${nbAssertions(3)} });`,
options: [3]
},
{
code: `${header} test(t => { notT.is(1, 1); notT.is(1, 1); notT.is(1, 1); });`,
options: [2]
},
// shouldn't be triggered since it's not a test file
`test(t => { ${nbAssertions(10)} });`
],
invalid: [
{
code: `${header} test(t => { ${nbAssertions(6)} });`,
errors
},
{
code: `${header}
test(t => { ${nbAssertions(3)} });
test(t => { ${nbAssertions(6)} });
`,
errors
},
{
code: `${header} test(t => { t.plan(5); ${nbAssertions(6)} });`,
errors
},
{
code: `${header} test(t => { t.skip.is(1, 1); ${nbAssertions(5)} });`,
errors
},
{
code: `${header} test.cb(t => { ${nbAssertions(6)} t.end(); });`,
errors
},
{
code: `${header} test(t => { ${nbAssertions(4)} });`,
options: [3],
errors
},
{
code: `${header} test(t => { ${nbAssertions(10)} });`,
errors
},
{
code: `${header} test(t => { ${nbAssertions(10)} }); test(t => { ${nbAssertions(10)} });`,
errors: errors.concat(errors) // Should have two errors, one per test
}
]
});
errors
},
{
code: `${header} test(t => { t.plan(5); ${nbAssertions(6)} });`,
errors
},
{
code: `${header} test(t => { t.skip.is(1, 1); ${nbAssertions(5)} });`,
errors
},
{
code: `${header} test.cb(t => { ${nbAssertions(6)} t.end(); });`,
errors
},
{
code: `${header} test(t => { ${nbAssertions(4)} });`,
options: [3],
errors
},
{
code: `${header} test(t => { ${nbAssertions(10)} });`,
errors
},
{
code: `${header} test(t => { ${nbAssertions(10)} }); test(t => { ${nbAssertions(10)} });`,
errors: errors.concat(errors) // Should have two errors, one per test
}
]
});
50 changes: 24 additions & 26 deletions test/no-cb-test.js
View file
Open in desktop
@@ -1,8 +1,8 @@
import test from 'ava';
import {RuleTester} from 'eslint';
import avaRuleTester from 'eslint-ava-rule-tester';
import rule from '../rules/no-cb-test';

const ruleTester = new RuleTester({
const ruleTester = avaRuleTester(test, {
env: {
es6: true
}
Expand All @@ -11,28 +11,26 @@ const ruleTester = new RuleTester({
const errors = [{ruleId: 'no-cb-test'}];
const header = `const test = require('ava');\n`;

test(() => {
ruleTester.run('no-cb-test', rule, {
valid: [
header + 'test("my test name", t => { t.pass(); });',
header + 'test.only("my test name", t => { t.pass(); });',
header + 'notTest.cb(t => { t.pass(); });',
// shouldn't be triggered since it's not a test file
'test.cb(t => {});'
],
invalid: [
{
code: header + 'test.cb(t => { t.pass(); });',
errors
},
{
code: header + 'test.cb.skip(t => { t.pass(); t.end(); });',
errors
},
{
code: header + 'test.skip.cb(t => { t.pass(); t.end(); });',
errors
}
]
});
ruleTester.run('no-cb-test', rule, {
valid: [
header + 'test("my test name", t => { t.pass(); });',
header + 'test.only("my test name", t => { t.pass(); });',
header + 'notTest.cb(t => { t.pass(); });',
// shouldn't be triggered since it's not a test file
'test.cb(t => {});'
],
invalid: [
{
code: header + 'test.cb(t => { t.pass(); });',
errors
},
{
code: header + 'test.cb.skip(t => { t.pass(); t.end(); });',
errors
},
{
code: header + 'test.skip.cb(t => { t.pass(); t.end(); });',
errors
}
]
});