Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'previous failures' in watch mode always incrementing #3297

Merged
merged 2 commits into from Jan 28, 2024
Merged

Fix 'previous failures' in watch mode always incrementing #3297

merged 2 commits into from Jan 28, 2024

Commits on Jan 28, 2024

  1. Fix 'previous failures' in watch mode always incrementing 

    The counters used absolute paths for the test files, but the clearing logic used relative paths. Count using relative paths instead.

The number of previous failures is not observable to the test harness, so this does not come with test coverage.

Fixes #3295.
    @novemberborn
    novemberborn committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    98c63d9 View commit details
    Browse the repository at this point in the history

  2. Fix external-assertions snapshot for Node.js 20.11 

    Vary the snapshots by minor version were appropriate.
    @novemberborn
    novemberborn committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    30d61d3 View commit details
    Browse the repository at this point in the history