Test with AVA 6 #3282
Merged
Test with AVA 6 #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
novemberborn
commented
Dec 30, 2023
novemberborn
commented
- Ensure watcher tests exit cleanly
- Test with AVA 6
novemberborn
force-pushed
the
test-with-ava6
branch
from
5e5d57a
to
a8effb4
Compare
|
Ironically, in CI the watch mode tests fail to exit cleanly. It's fine locally. This will need #3279 to be resolved and available through the |
novemberborn
force-pushed
the
test-with-ava6
branch
2 times, most recently
from
8fbafd3
to
9bfb21b
Compare
Turns out this is due to a bug on Linux with our test for recursive watch support leaking referenced file handles. |
Always await the last pending state when the watch runs have completed. Use a teardown hook to ensure the watcher is aborted and has exited before ending the test. Ensure the item is always an object, even if it didn't come from the generator.
Otherwise, on Linux, it seems the abort signal is disregarded.
novemberborn
force-pushed
the
test-with-ava6
branch
from
f840a82
to
c09a35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.