Refactor error processing #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies error serialization, relying on the advanced IPC for child processes & worker threads. Unnecessary code has been removed. Possibly breaking changes: * Renamed and removed fields from the undocumented AssertionError class, including the raw values * Changes to the undocumented TAP output; stack traces are a bit worse, the rest is about the same but some fields have different names or values * `nyc` stack frames are no longer ignored; we assume you're using the native code coverage tools
novemberborn
force-pushed
the
error-serialization
branch
from
4363619
to
1185633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies error serialization, relying on the advanced IPC for child processes & worker threads. Unnecessary code has been removed.
Possibly breaking changes:
nycstack frames are no longer ignored; we assume you're using the native code coverage tools