Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle findSourceMap returning null since Node.js 18.8.0 #3091

Merged
merged 3 commits into from Aug 25, 2022
Merged

Handle findSourceMap returning null since Node.js 18.8.0 #3091

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
394ed93
findSourceMap return null since Node.js 18.8.0
Brooooooklyn Aug 25, 2022
38d316f
Apply CR suggestion
Brooooooklyn Aug 25, 2022
7fd9311
Amend comment
novemberborn Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/snapshot-manager.js
View file
Open in desktop
Expand Up @@ -391,7 +391,10 @@ class Manager {

const resolveSourceFile = mem(file => {
const sourceMap = findSourceMap(file);
if (sourceMap === undefined) {
// since Node.js 18.8.0, the return value of `findSourceMap` changed to null if not found
// it was `undefined` in previous version
// https://github.com/nodejs/node/pull/43875
if (sourceMap == undefined) {
Brooooooklyn marked this conversation as resolved.
Show resolved Hide resolved
return file;
}

Expand Down