Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing of teardown methods #3003

Merged
merged 2 commits into from Apr 10, 2022
Merged

Improve typing of teardown methods #3003

merged 2 commits into from Apr 10, 2022

Commits on Apr 5, 2022

  1. Explicitly type t.teardown() functions to return a promise 

    This helps with the @typescript-eslint/no-misused-promises ESLint rule.
    @novemberborn
    novemberborn committed Apr 5, 2022
    Copy the full SHA
    d4c8469 View commit details
    Browse the repository at this point in the history

  2. Fix typing of plugin teardown 

    The returned method always returns Promise<void>. The teardown function itself may or may not return a promise. Support both to help with the @typescript-eslint/no-misused-promises ESLint rule.
    @novemberborn
    novemberborn committed Apr 5, 2022
    Copy the full SHA
    fb7614b View commit details
    Browse the repository at this point in the history