Attempt to use TS 4.5 type resolution #2858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolution Plugins are experimental so we can mandate TS 4.5 to get TS support.
Add TS 4.5 type resolution, with fallback for TS 4.4.
|
Also, sadly, it doesn't let us provide different type definitions based on the import mechanism, so it doesn't let us remove #2836. |
|
TypeScript has removed these features from 4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#esm-nodejs this tries to tell TypeScript where to find the type definitions through the
exportsfield. It doesn't seem to work though withava/plugin, so I'll leave this as a draft for now.