Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle findSourceMap returning null since Node.js 18.8.0 #3091

Merged
merged 3 commits into from Aug 25, 2022

Conversation

Brooooooklyn
Copy link
Contributor

No description provided.

@iambumblehead
Copy link

this issue is causing the CI pipeline here to fail https://github.com/iambumblehead/esmock/runs/8011056406?check_suite_focus=true

@novemberborn
Copy link
Member

Nice find @Brooooooklyn. Too bad the documentation doesn't define behavior when the source map cannot be found. I guess that's what we get for using an experimental feature.

@novemberborn novemberborn changed the title findSourceMap return null since Node.js 18.8.0 Handle findSourceMap returning null since Node.js 18.8.0 Aug 25, 2022
@novemberborn novemberborn merged commit f4067b2 into avajs:main Aug 25, 2022
@Brooooooklyn Brooooooklyn deleted the fix-source-map branch August 25, 2022 13:01
@novemberborn
Copy link
Member

Should be fixed in 4.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants