Code sync to go-ethereum v1.13.14 #1152
Draft
+5,045
−4,755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into geth-v1.13.8
…m into geth-v1.13.8
This reverts commit 09d505bd5e906ac186643061437e665b116b5bf6.
darioush
commented
Apr 17, 2024
|
|
||
| log.Info("Closing quit channel") | ||
| close(bc.quit) | ||
| close(bc.quit) // XXX: Why is this closed before [scope] but it's opposite upstream? |
There was a problem hiding this comment.
Why is bc.quit closed before scope but it's opposite upstream?
| "bytes" | ||
| _ "embed" | ||
| "encoding/hex" | ||
| _ "embed" // XXX: why is this import here? |
| PrivateKey []byte `json:"secretKey,omitempty"` // for tests | ||
| } | ||
|
|
||
| // XXX: why is BaseFee/Alloc ordered differently compared to upstream? |
There was a problem hiding this comment.
Does the different ordering matter? if not should we put it back?
| ) | ||
|
|
||
| // TODO: simplify the unindexer logic and this test. | ||
| // XXX: These tests are moved from blockchain_test.go here. |
There was a problem hiding this comment.
this test was deleted upstream, but it's the one we modified.
maybe we should move this to txindexer_extra_test.go?
| stateObject := s.getStateObject(addr) | ||
| if stateObject != nil { | ||
| return stateObject.Balance() | ||
| } | ||
| return new(big.Int).Set(common.Big0) | ||
| return common.U2560 // XXX: verify we don't need to make a copy of this |
There was a problem hiding this comment.
probably we should make a copy of this to be safe
| // AdjustTime changes the block timestamp and creates a new block. | ||
| // It can only be called on empty blocks. | ||
| func (n *Backend) AdjustTime(adjustment time.Duration) error { | ||
| _, err := n.buildBlock(false, uint64(adjustment)) // XXX: shouldn't the granularity be in seconds? |
There was a problem hiding this comment.
this doesn't seem right to me, block timestamps should be in seconds?
| @@ -213,7 +213,8 @@ func (c *ChainConfig) Description() string { | |||
| } | |||
|
|
|||
| banner += "Hard forks (timestamp based):\n" | |||
| banner += fmt.Sprintf(" - Cancun Timestamp: @%-10v (https://github.com/ava-labs/avalanchego/releases/tag/v1.12.0)\n", ptrToString(c.CancunTime)) | |||
| banner += fmt.Sprintf(" - Cancun Timestamp: @%-10v (https://github.com/ava-labs/avalanchego/releases/tag/v1.12.0)\n", ptrToString(c.CancunTime)) /// XXX: should we link the ethereum execution spec here instead | |||
There was a problem hiding this comment.
cosmetic issue, but we can link the ethereum spec here
| @@ -117,7 +118,8 @@ func mintNativeCoin(accessibleState contract.AccessibleState, caller common.Addr | |||
| stateDB.CreateAccount(to) | |||
| } | |||
|
|
|||
| stateDB.AddBalance(to, amount) | |||
| amountU256, _ := uint256.FromBig(amount) // XXX: should we check overflow? | |||
| bigIntAmount := (*big.Int)(amount) | ||
| state.AddBalance(to, bigIntAmount) | ||
| amountBig := (*big.Int)(amount) | ||
| amountU256, _ := uint256.FromBig(amountBig) // XXX: should we check overflow? |
| @@ -29,7 +30,8 @@ func upgradeAccount(account common.Address, upgrade params.StateUpgradeAccount, | |||
| } | |||
|
|
|||
| if upgrade.BalanceChange != nil { | |||
| state.AddBalance(account, (*big.Int)(upgrade.BalanceChange)) | |||
| balanceChange, _ := uint256.FromBig((*big.Int)(upgrade.BalanceChange)) // XXX: do we need to check overflow? | |||
darioush
commented
Apr 17, 2024
Comment on lines
+109
to
+110
| // NonceAt retrieves the nonce associated with an account. | ||
| NonceAt(ctx context.Context, account common.Address, blockNum *big.Int) (uint64, error) |
There was a problem hiding this comment.
need to be able to build on top of the nonce in the txpool, not the accepted nonce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Takes code from upstream
How this works
Takes code from upstream
How this was tested
[ ] CI
[ ] testnet
How is this documented
N/A