plugin: listen on IP address #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
go-plugin seems to work with unix? https://github.com/hashicorp/go-plugin/blob/044aadd925bf9f027cb301b2af9bc6b60775dd22/docs/internals.md#handshake |
|
Yeah its not a limitation persay it was a design decision to support abstract unix sockets vs unix sockets. But as tonic does not support this yet we have tcp listener. Will add comments |
Signed-off-by: Sam Batschelet <sam.batschelet@avalabs.org>
gyuho
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently avalanche go only supports plugins listening on IP address. In the future we will add support for abstract unix sockets once the support is added for tonic[1].
[1] hyperium/tonic#966