Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test kit to use minSdk, targetSdk, compileSdk, and an equals after applicationId and namespace #1187

Merged

Conversation

j-roskopf
Copy link
Contributor

I was using testkit to create an android project locally, and I didn't see anyway to overwrite the default values for the android block.

@j-roskopf j-roskopf changed the title Update test kit to use minSdk, targetSdk, compileSdk, and an equals after applicationId Update test kit to use minSdk, targetSdk, compileSdk, and an equals after applicationId and namespace May 14, 2024
Copy link
Owner

@autonomousapps autonomousapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. In which version of AGP were these property names updated?

@j-roskopf
Copy link
Contributor Author

I'm not entirely sure the exact version! I created a new sample project and used AGP 7.0 and saw the properties were still deprecated, so I'm assuming pre 7.0 they were deprecated

@autonomousapps
Copy link
Owner

Thanks!

@autonomousapps autonomousapps merged commit dec044a into autonomousapps:main May 23, 2024
1 check passed
@j-roskopf
Copy link
Contributor Author

@autonomousapps do you have an inkling to when this would be released?

@autonomousapps
Copy link
Owner

@autonomousapps do you have an inkling to when this would be released?

Can't make any promises, so let's go with Soon ™️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants