[WIP][DO NOT MERGE] Update version of torch, lightning, transformers in multimodal #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HPO error due to ray-project/ray#27770 |
Innixma
reviewed
Nov 29, 2022
| "torch>=1.9,<1.13", | ||
| "torchvision<0.14.0", | ||
| "torchtext<0.14.0", | ||
| "torch>=1.9,<1.14", |
There was a problem hiding this comment.
You'll need to update tabular's fastai extra_dependencies key since it also requires torch. Maybe we move torch to the _setup_utils.py file so we ensure consistent versions across the package?
| @@ -892,8 +892,9 @@ def _hyperparameter_tune(self, hyperparameter_tune_kwargs, resources, **_fit_arg | |||
| ) | |||
|
|
|||
| ray_tune_adapter = AutommRayTuneAdapter() | |||
| if try_import_ray_lightning(): | |||
| ray_tune_adapter = AutommRayTuneLightningAdapter() | |||
| # Do not use ray lightning. | |||
gradientsky
reviewed
Jan 5, 2023
| "torch>=1.9,<1.13", | ||
| "torchvision<0.14.0", | ||
| "torchtext<0.14.0", | ||
| "torch>=1.9,<1.14", |
There was a problem hiding this comment.
security concern: 1.12.x have critical RCE CVEs open against it. pytorch is not planning to fix it in 1.12.x, I suggest capping it from the bottom to >=1.13.1?
gradientsky
reviewed
Jan 5, 2023
| @@ -21,7 +21,7 @@ function setup_mxnet_gpu { | |||
| } | |||
|
|
|||
| function setup_torch_gpu { | |||
| python3 -m pip install torch==1.12.0+cu113 torchvision==0.13.0+cu113 --extra-index-url https://download.pytorch.org/whl/cu113 | |||
| python3 -m pip install torch==1.13.0+cu117 torchvision==0.14.0+cu117 --extra-index-url https://download.pytorch.org/whl/cu117 | |||
There was a problem hiding this comment.
Please update to 1.13.1+ (see my other comment)
There was a problem hiding this comment.
Thanks! Will do it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update version of the dependencies in multimodal.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.