Bug in CircularDependency tracking #579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"var activation = new InstanceLookup(registration, this, currentOperationScope, parameters);" can raise exception resulting in inconsistent _callDepth value with _activationStack.
|
Sounds like a nice catch. Can you provide a unit test to demonstrate the problem and prove the fix? |
|
I believe we're still looking for a unit test on this one before we can pull it in, yes? |
|
This has been sitting for a while and is now not able to be taken due to changes in the branching structure. We also are still unclear on what specific use case this fixes since there is no test. I'm going to link this to issue #477 as a place to improve circular dependency handling. |
|
Correction: follow this on #798. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error in InstanceLookup constructor may result in Exception when attempting to find scope, such an exception cause inconsistent _callDepth value.
This can cause a CircularDependency exception by reaching the threshold of the max depth.