Remove IsTopLevelOperation and ITracingIdentifier #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tillig, apologies for any merge fun you have into your branch; don't know if you want me to just retarget this onto your issue-788 branch? |
|
Actually, I'll be selfish this time and ask, yeah, please do target my branch and it'll all go in v6 at once. Thanks! |
alistairjevans
force-pushed
the
remove-toplevel-operation
branch
from
5ac749a
to
c316344
Compare
|
Changed target branch to issue-788. Tests are failing, but they were already failing. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of parent vs child operations were only relevant when Decorators required a brand new
ResolveOperationso they got a clean circular dependency stack.The introduction of the
SegmentedStackin #1148 meant we didn't need this construct, and it confuses the diagnostic tracing functionality, so I'm taking it out.