Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflection Constructor Binding Refactor #1155

Merged
merged 11 commits into from
Jun 29, 2020
Merged

Reflection Constructor Binding Refactor #1155

merged 11 commits into from
Jun 29, 2020

Commits on Jun 26, 2020

  1. Refactor the constructor binder to more work up-front, and allocate l… 

    …ess.
    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    875126c View commit details
    Browse the repository at this point in the history

  2. Stylecop conformance, remove old binder. 

    Stylecop conformance.
    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    3f5d48f View commit details
    Browse the repository at this point in the history

  3. Make the bind result a class instead of a struct, copying is happening

    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    fe88889 View commit details
    Browse the repository at this point in the history

  4. Switch to manual enumeration of parameters, rather than using concat

    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    904ddf0 View commit details
    Browse the repository at this point in the history

  5. Still want the conditional to reuse default parameters array without … 

    …re-enumerating
    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    7c4af6e View commit details
    Browse the repository at this point in the history

  6. Don't lock and then yield return inside it! Performance sad.

    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    d1768e1 View commit details
    Browse the repository at this point in the history

  7. Cache the constructor factory delegates, but only during Activation. 

    Saves the rebuild of the delegate if someone re-registers the type in a nested scope.
    @alistairjevans
    alistairjevans committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    54ca7c9 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. Switched BoundConstructor to have named factory methods. Fixed minor … 

    …issues in the constructor expression builder.
    @alistairjevans
    alistairjevans committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    2510b48 View commit details
    Browse the repository at this point in the history

  2. Refactor MostParametersConstructorSelector for perf, and to zero-allo… 

    …cate.
    @alistairjevans
    alistairjevans committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    5025e37 View commit details
    Browse the repository at this point in the history

  3. Constructor Selectors now receive the entire set of all bindings, inc… 

    …luding any invalid ones.

This saves re-allocating a new array in the case of one invalid binding.
    @alistairjevans
    alistairjevans committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    78b821c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Fix message typo.

    @alistairjevans
    alistairjevans committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    16e5b89 View commit details
    Browse the repository at this point in the history