Fix Issue#963: Partially decorating service implementing multiple interfaces throws #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillig
requested changes
Jan 27, 2020
There was a problem hiding this comment.
I think this is looking good. I'd like to see if we can solve it without breaking the public interface, but otherwise I dig it. If we do have to break the public interface... Unclear on how best to deal with that from a versioning standpoint. Likely few people are actually relying on that particular method, so maybe we could get away with a 0.1.0 increment?
|
Thanks for the help on this one @RaymondHuy! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #963: Add target component to be decorated to the decorating process so that we can get the InstanceSharing.