Memory optimization from #919: Autofac.Core.Resolving.CircularDepende…

…ncyDetector.
autofac · Aug 16, 2018 · fc17758 · fc17758
1 parent 06a0bbf
commit fc17758
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/Autofac/Core/Resolving/CircularDependencyDetector.cs b/src/Autofac/Core/Resolving/CircularDependencyDetector.cs
@@ -63,8 +63,13 @@ public static void CheckForCircularDependency(IComponentRegistration registratio
                 throw new DependencyResolutionException(string.Format(CultureInfo.CurrentCulture, CircularDependencyDetectorResources.MaxDepthExceeded, registration));
 
             // Checks for circular dependency
-            if (activationStack.Any(a => a.ComponentRegistration == registration))
-                throw new DependencyResolutionException(string.Format(CultureInfo.CurrentCulture, CircularDependencyDetectorResources.CircularDependency, CreateDependencyGraphTo(registration, activationStack)));
+            foreach (var a in activationStack)
+            {
+                if (a.ComponentRegistration == registration)
+                {
+                    throw new DependencyResolutionException(string.Format(CultureInfo.CurrentCulture, CircularDependencyDetectorResources.CircularDependency, CreateDependencyGraphTo(registration, activationStack)));
+                }
+            }
         }
     }
 }