Skip to content

Commit

Permalink
DiagosticSource is not CLSCompliant.
Browse files Browse the repository at this point in the history
  • Loading branch information
@tillig
tillig committed Jul 7, 2020
1 parent 87f2148 commit 8f01e36
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Autofac/Properties/AssemblyInfo.cs
View file
Expand Up @@ -8,8 +8,8 @@
[assembly: InternalsVisibleTo("Autofac.Test, PublicKey=00240000048000009400000006020000002400005253413100040000010001008728425885ef385e049261b18878327dfaaf0d666dea3bd2b0e4f18b33929ad4e5fbc9087e7eda3c1291d2de579206d9b4292456abffbe8be6c7060b36da0c33b883e3878eaf7c89fddf29e6e27d24588e81e86f3a22dd7b1a296b5f06fbfb500bbd7410faa7213ef4e2ce7622aefc03169b0324bcd30ccfe9ac8204e4960be6")]
[assembly: InternalsVisibleTo("Autofac.Test.Uwp.DeviceRunner, PublicKey=00240000048000009400000006020000002400005253413100040000010001008728425885ef385e049261b18878327dfaaf0d666dea3bd2b0e4f18b33929ad4e5fbc9087e7eda3c1291d2de579206d9b4292456abffbe8be6c7060b36da0c33b883e3878eaf7c89fddf29e6e27d24588e81e86f3a22dd7b1a296b5f06fbfb500bbd7410faa7213ef4e2ce7622aefc03169b0324bcd30ccfe9ac8204e4960be6")]
[assembly: InternalsVisibleTo("Autofac.Net46.Test, PublicKey=00240000048000009400000006020000002400005253413100040000010001008728425885ef385e049261b18878327dfaaf0d666dea3bd2b0e4f18b33929ad4e5fbc9087e7eda3c1291d2de579206d9b4292456abffbe8be6c7060b36da0c33b883e3878eaf7c89fddf29e6e27d24588e81e86f3a22dd7b1a296b5f06fbfb500bbd7410faa7213ef4e2ce7622aefc03169b0324bcd30ccfe9ac8204e4960be6")]
[assembly: CLSCompliant(true)]
[assembly: CLSCompliant(false)]
[assembly: ComVisible(false)]
[assembly: NeutralResourcesLanguage("en-US")]
[assembly: AssemblyCopyright("Copyright © 2015 Autofac Contributors")]
[assembly: AssemblyDescription("Autofac Inversion of Control container for .NET applications.")]
[assembly: AssemblyDescription("Autofac Inversion of Control container for .NET applications.")]

2 comments on commit 8f01e36

@Gineus
Copy link

@Gineus Gineus commented on 8f01e36 Nov 26, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tillig Can you give a little bit more background why CLSCompliant(false) is needed? Is it because of the DiagnosticSourceExtensions?

@tillig
Copy link
Member Author

@tillig tillig commented on 8f01e36 Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use DiagnosticSource for providing diagnostics into the container and resolve operations. It's a new feature in v6 - check the release notes. This follows the pattern from ASP.NET Core where that's the mechanism for diagnostics. That class not being CLSCompliant is not within our control.

Please sign in to comment.