Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove e2e timeout #328

Merged
merged 1 commit into from Dec 8, 2021
Merged

Remove e2e timeout #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions e2e/newenemy/newenemy_test.go
View file
Open in desktop
Expand Up @@ -144,12 +144,9 @@ func TestNoNewEnemy(t *testing.T) {
iterations := int(math.Min(max_iterations, math.Ceil(3*stddev*samplestddev+mean)))

t.Logf("check spicedb is protected after %d attempts", iterations)
// *6 to cover the worst case where all requests are handled by the slow node
checkCtx, checkCancel := context.WithTimeout(ctx, time.Duration(iterations)*(networkDelay+timeDelay)*6)
protected, _ := checkNoNewEnemy(checkCtx, t, protectedSpiceDb, iterations)
protected, _ := checkNoNewEnemy(ctx, t, protectedSpiceDb, iterations)
require.NotNil(protected, "unable to determine if spicedb is protected within the time limit")
require.True(*protected, "protection is enabled, but newenemy detected")
checkCancel()
}

// checkNoNewEnemy returns true if the service is protected, false if it is vulnerable, and nil if we couldn't determine
Expand Down