Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds OpenTelemetry TraceID to logs #1772

Merged
merged 1 commit into from
Mar 11, 2024
Merged

adds OpenTelemetry TraceID to logs #1772

merged 1 commit into from
Mar 11, 2024

Conversation

vroldanbet
Copy link
Contributor

so we can correlate logs, traces and metric exemplars

@vroldanbet vroldanbet requested a review from a team as a code owner March 1, 2024 13:42
@vroldanbet vroldanbet self-assigned this Mar 1, 2024
@github-actions github-actions bot added the area/CLI Affects the command line label Mar 1, 2024
so we can correlate logs, traces and metric exemplars
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if there's some way we could unify request IDs with traceIDs

@vroldanbet vroldanbet added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 74d6048 Mar 11, 2024
20 checks passed
@vroldanbet vroldanbet deleted the add-trace-id-to-logs branch March 11, 2024 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
@vroldanbet
Copy link
Contributor Author

vroldanbet commented Mar 12, 2024

I wonder if there's some way we could unify request IDs with traceIDs

Yeah, I've had the a similar thought. We'd need to read a bit about Otel TraceIDs and determine if it has any restriction that would prevent us from feeding the requestID into it. Is that what you had in mind?

Opened #1789

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/CLI Affects the command line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants