Proper handling of incompatible zedtokens #1723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
josephschorr
force-pushed
the
incompatible-zedtokens
branch
3 times, most recently
from
d3b259f
to
64dda15
Compare
josephschorr
force-pushed
the
incompatible-zedtokens
branch
from
64dda15
to
8f8f83c
Compare
josephschorr
force-pushed
the
incompatible-zedtokens
branch
from
8f8f83c
to
8c87502
Compare
|
Rebased |
josephschorr
force-pushed
the
incompatible-zedtokens
branch
2 times, most recently
from
52895fe
to
9bb170d
Compare
josephschorr
force-pushed
the
incompatible-zedtokens
branch
from
9bb170d
to
d15a06b
Compare
|
Rebased |
josephschorr
force-pushed
the
incompatible-zedtokens
branch
from
d15a06b
to
ba65181
Compare
an older datastore is used All ZedTokens are now minted with the datastore's unique ID included in the ZedToken and that ID is checked when the ZedToken is decoded. In scenarios where the datastore ID does not match, either an error is raised (watch, at_exact_snapshot) or configurable behavior is used (at_least_as_fresh) Fixes authzed#1541
josephschorr
force-pushed
the
incompatible-zedtokens
branch
from
ba65181
to
160e514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: ZedTokens are a bit longer now as a result of this change, but should still be well within the 1024 limit previously defined