don't treat "" as a special case, avoid calling instead

internal/datastore/postgres/postgres.go

@@ -146,10 +146,13 @@ func newPostgresDatastore(
 		return nil, common.RedactAndLogSensitiveConnString(ctx, errUnableToInstantiate, err, pgURL)
 	}
 
-	// Setup the credential provider
-	credentialsProvider, err := datastore.NewCredentialsProvider(ctx, config.credentialsProviderName)
-	if err != nil {
-		return nil, err
+	// Setup the credentials provider
+	var credentialsProvider datastore.CredentialsProvider
+	if config.credentialsProviderName != "" {
+		credentialsProvider, err = datastore.NewCredentialsProvider(ctx, config.credentialsProviderName)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	// Setup the config for each of the read and write pools.

pkg/cmd/migrate.go

@@ -60,10 +60,14 @@ func migrateRun(cmd *cobra.Command, args []string) error {
 	} else if datastoreEngine == "postgres" {
 		log.Ctx(cmd.Context()).Info().Msg("migrating postgres datastore")
 
+		var credentialsProvider datastore.CredentialsProvider
 		credentialsProviderName := cobrautil.MustGetString(cmd, "datastore-credentials-provider-name")
-		credentialsProvider, err := datastore.NewCredentialsProvider(cmd.Context(), credentialsProviderName)
-		if err != nil {
-			return err
+		if credentialsProviderName != "" {
+			var err error
+			credentialsProvider, err = datastore.NewCredentialsProvider(cmd.Context(), credentialsProviderName)
+			if err != nil {
+				return err
+			}
 		}
 
 		migrationDriver, err := migrations.NewAlembicPostgresDriver(cmd.Context(), dbURL, credentialsProvider)

pkg/datastore/credentials.go

@@ -49,9 +49,6 @@ func CredentialsProviderOptions() string {
 // NewCredentialsProvider create a new CredentialsProvider for the given name
 // returns an error if no match is found, of if there is a problem creating the given CredentialsProvider
 func NewCredentialsProvider(ctx context.Context, name string) (CredentialsProvider, error) {
-	if name == "" {
-		return NoCredentialsProvider, nil
-	}
 	builder, ok := BuilderForCredentialProvider[name]
 	if !ok {
 		return nil, fmt.Errorf("unknown credentials provider: %s", name)

pkg/datastore/credentials_test.go

@@ -7,14 +7,8 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestNoCredentialsProvider(t *testing.T) {
-	credentialsProvider, err := NewCredentialsProvider(context.Background(), "")
-	require.Equal(t, NoCredentialsProvider, credentialsProvider)
-	require.NoError(t, err)
-}
-
 func TestUnknownCredentialsProvider(t *testing.T) {
-	unknownCredentialsProviders := []string{"some-unknown-credentials-provider", "  "}
+	unknownCredentialsProviders := []string{"", " ", "some-unknown-credentials-provider"}
 	for _, unknownCredentialsProvider := range unknownCredentialsProviders {
 		t.Run(unknownCredentialsProvider, func(t *testing.T) {
 			credentialsProvider, err := NewCredentialsProvider(context.Background(), unknownCredentialsProvider)