golangci-lint: enable unconvert

authzed · Dec 26, 2021 · 1ee0025 · 1ee0025
1 parent b7aa5f8
commit 1ee0025
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -41,6 +41,7 @@ linters:
     - "stylecheck"
     - "tenv"
     - "typecheck"
+    - "unconvert"
     - "unused"
     - "varcheck"
 issues:

diff --git a/internal/datastore/postgres/postgres.go b/internal/datastore/postgres/postgres.go
@@ -260,7 +260,7 @@ func (pgd *pgDatastore) getNow(ctx context.Context) (time.Time, error) {
 func (pgd *pgDatastore) collectGarbage() error {
 	startTime := time.Now()
 	defer func() {
-		gcDurationHistogram.Observe(float64(time.Since(startTime).Seconds()))
+		gcDurationHistogram.Observe(time.Since(startTime).Seconds())
 	}()
 
 	ctx, cancel := context.WithTimeout(context.Background(), pgd.gcMaxOperationTime)

diff --git a/pkg/schemadsl/input/sourcepositionmapper.go b/pkg/schemadsl/input/sourcepositionmapper.go
@@ -31,9 +31,9 @@ func CreateSourcePositionMapper(contents []byte) SourcePositionMapper {
 
 	currentStart := int(0)
 	for index, line := range lines {
-		lineEnd := currentStart + int(len(line))
-		rangeTree.Put(inclusiveRange{currentStart, lineEnd}, lineAndStart{int(index), currentStart})
-		lineMap[int(index)] = inclusiveRange{currentStart, lineEnd}
+		lineEnd := currentStart + len(line)
+		rangeTree.Put(inclusiveRange{currentStart, lineEnd}, lineAndStart{index, currentStart})
+		lineMap[index] = inclusiveRange{currentStart, lineEnd}
 		currentStart = lineEnd + 1
 	}