Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 4-7 support #801

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove node 4-7 support #801

wants to merge 3 commits into from

Conversation

RDIL
Copy link

@RDIL RDIL commented Dec 28, 2021

Description

This is a breaking change - it removes the support for node 4-7, since those versions are very old and not widely used anymore.

Pros:

  • Removes the dependency on semver
  • Removes the splice calls
  • Slight reduction of code size

Cons:

  • For the few people out there still using these versions, they will be forced to either update node or stay on an old library version.

If the maintainers aren't interested in dropping support for these old versions, that's fine, I just think that this change is (while breaking), harmless enough, because I really don't know of anybody who is still using node 4, 5, 6, or 7.

References

None really.

Testing

Unit tests should still be passing.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@RDIL RDIL changed the title Remove node version checks Remove node 4-7 support Dec 28, 2021
@@ -17,55 +17,43 @@ commands:
command: npm test

jobs:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI config, I've opted to change it to primarily using even-numbered releases, as they are the long-term-support versions, whereas the odd numbers are essentially development versions. It doesn't really make sense to test against, say node 9 or 11, the majority of people use the stable versions such as 10 or 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant