Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ClientsManager.rotateClientSecret method #721

Merged
merged 5 commits into from May 19, 2022

Conversation

sbmelvin
Copy link
Contributor

@sbmelvin sbmelvin commented May 18, 2022

Changes

Please describe both what is changing and why this is important. Include:

Added ClientsManager.rotateClientSecret method to handle calls to the'Rotate Client Secret' endpoint.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

Checklist

@sbmelvin sbmelvin requested a review from a team as a code owner May 18, 2022 14:55
@adamjmcgrath
Copy link
Member

LGTM 👍

Just need to add the client_id check back (and you probably need a test case for it to make Codecov happy)

Stephen Melvin added 2 commits May 18, 2022 12:09
Added unit test for client_id check.
@sbmelvin
Copy link
Contributor Author

LGTM 👍

Just need to add the client_id check back (and you probably need a test case for it to make Codecov happy)

Added check.

@adamjmcgrath
Copy link
Member

Thanks @sbmelvin!

@adamjmcgrath adamjmcgrath merged commit 0ed8919 into auth0:master May 19, 2022
@sbmelvin
Copy link
Contributor Author

👍
Would you know when the next release might be?

@adamjmcgrath adamjmcgrath mentioned this pull request May 20, 2022
@adamjmcgrath
Copy link
Member

Hi @sbmelvin 👋 this has been released in https://github.com/auth0/node-auth0/releases/tag/v2.41.0

@sbmelvin
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants