Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong property in assignRolestoUser #700

Merged
merged 2 commits into from Jan 27, 2022
Merged

Fix wrong property in assignRolestoUser #700

merged 2 commits into from Jan 27, 2022

Conversation

adamjmcgrath
Copy link
Member

@adamjmcgrath adamjmcgrath commented Jan 27, 2022 •
edited

assignRolestoUser was calling roles.assignRoles, when it should have been calling users.assignRoles

References

fixes #698

Testing

  • This change adds unit test coverage

@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Jan 27, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner January 27, 2022 10:14
@adamjmcgrath adamjmcgrath merged commit 77dcee5 into master Jan 27, 2022
@adamjmcgrath adamjmcgrath deleted the fix-assign-roles-to-user branch January 27, 2022 11:13
@adamjmcgrath adamjmcgrath mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Management Client - assignRolestoUser throws error in 2.38.0
2 participants
@adamjmcgrath @frederikprijck