Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(migrations): adds migrations manager #503

Merged
merged 7 commits into from Jun 30, 2020
Merged

feat(migrations): adds migrations manager #503

merged 7 commits into from Jun 30, 2020

Conversation

CriGoT
Copy link
Contributor

@CriGoT CriGoT commented Jun 26, 2020

Changes

  • Adds support for the /migrations endpoint which supports GET and PATCH operations
  • Adds MigrationsManager to handle the new endpoint
  • The new endpoint provides a mechanism to enable/disable ongoing migrations for the tenant.

Testing

Added migrations.test.js

This was referenced Jun 26, 2020
Merged
Merged
FadyMak
FadyMak reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@FadyMak FadyMak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minor suggestions to apply

src/management/index.js Outdated Show resolved Hide resolved
src/management/MigrationsManager.js Outdated Show resolved Hide resolved
src/management/MigrationsManager.js Outdated Show resolved Hide resolved
src/management/MigrationsManager.js Outdated Show resolved Hide resolved
src/management/MigrationsManager.js Outdated Show resolved Hide resolved
CriGoT and others added 5 commits June 30, 2020 11:59
@CriGoT @FadyMak
Update src/management/index.js
f87cbb0 
Co-authored-by: Fady Makram <fmakram1@gmail.com>
@CriGoT @FadyMak
Update src/management/MigrationsManager.js
4df261b 
Co-authored-by: Fady Makram <fmakram1@gmail.com>
@CriGoT @FadyMak
Update src/management/MigrationsManager.js
fdf6ec0 
Co-authored-by: Fady Makram <fmakram1@gmail.com>
@CriGoT @FadyMak
Update src/management/MigrationsManager.js
ba68ae9 
Co-authored-by: Fady Makram <fmakram1@gmail.com>
@CriGoT @FadyMak
Update src/management/MigrationsManager.js
9ef2435 
Co-authored-by: Fady Makram <fmakram1@gmail.com>
@CriGoT CriGoT marked this pull request as ready for review June 30, 2020 16:01
@CriGoT CriGoT requested a review from a team June 30, 2020 16:01
@davidpatrick davidpatrick added this to the v2Next milestone Jun 30, 2020
@davidpatrick davidpatrick merged commit a145941 into auth0:master Jun 30, 2020
@CriGoT CriGoT deleted the add-migrations-manager branch June 30, 2020 19:30
@davidpatrick davidpatrick mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

@FadyMak FadyMak FadyMak approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v2.27.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CriGoT @davidpatrick @FadyMak