Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Request lib #475

Merged
merged 1 commit into from Apr 14, 2020
Merged

Deprecate Request lib #475

merged 1 commit into from Apr 14, 2020

Conversation

davidpatrick
Copy link
Contributor

Changes

  • Replaced request library with axios
  • Added form-data library to handle form posting with axios
  • Removed no longer needed utility getRequestPromise
  • Updated jwks-rsa to 1.8.0

References

Closes #464

Testing

Validated request and error handling with axios.

@davidpatrick davidpatrick requested a review from a team April 14, 2020 05:47
@adamjmcgrath adamjmcgrath self-assigned this Apr 14, 2020
adamjmcgrath
adamjmcgrath requested changes Apr 14, 2020
View reviewed changes
test/auth/tokens-manager.tests.js Outdated Show resolved Hide resolved
@davidpatrick davidpatrick merged commit 32f0001 into auth0:master Apr 14, 2020
@davidpatrick davidpatrick deleted the deprecate-request branch April 14, 2020 21:29
@davidpatrick davidpatrick added this to the v2.25.0 milestone Apr 15, 2020
@davidpatrick davidpatrick mentioned this pull request Apr 15, 2020
Closed
@davidpatrick davidpatrick mentioned this pull request Apr 29, 2020
Merged
@taylorbryant taylorbryant mentioned this pull request May 1, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees

@adamjmcgrath adamjmcgrath

Labels
CH: Changed
Projects
None yet
Milestone
v2.25.0
Development

Successfully merging this pull request may close these issues.

Request lib is deprecated
2 participants
@davidpatrick @adamjmcgrath