Fix issue where error reporting wrong instanceof #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/7SxTE59cysaY4YZWGZF3pbbeAPRb |
adamjmcgrath
commented
Nov 18, 2021
| @@ -149,13 +149,6 @@ | |||
| } | |||
| }, | |||
| "preset": "ts-jest", | |||
| "globals": { | |||
There was a problem hiding this comment.
Using same target as project (es5) so I can have a regression test for this issue
adamjmcgrath
commented
Nov 18, 2021
| @@ -8,6 +8,7 @@ import { HttpError } from 'http-errors'; | |||
| export class AccessTokenError extends Error { | |||
| public code: string; | |||
|
|
|||
| /* istanbul ignore next */ | |||
There was a problem hiding this comment.
adamjmcgrath
commented
Nov 18, 2021
| import { AccessTokenError, HandlerError } from '../../src/utils/errors'; | ||
|
|
||
| describe('errors', () => { | ||
| test('should be instance of themselves', () => { |
There was a problem hiding this comment.
Believe it or not, this test will fail in TS with target: es5 without the Object.setPrototypeOf(this, ThisError.prototype); workaround
Widcket
approved these changes
Nov 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using the
instanceofoperator against theAccessTokenErrorconstructor always returns false, even if the object that is being tested is actually an instance ofAccessTokenError.This is an issue introduced in nextjs-auth0 v1.5.0 by microsoft/TypeScript#13965 when we downgraded the compilation target to
es5to support IE11 in c248efe#diff-3ae20d611c1c7263a9c1bce0449291ebfea1c5d578b3fcdbb596353ad885db25R19Using the workaround here https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#extending-built-ins-like-error-array-and-map-may-no-longer-work
References
fixes #535
Testing
Set the target for jest to be the same as the main binary, so I could add a test case for this regression.
Using target
es5on jest meant I had to add a couple ofignore next's to resolve an issue in istanbul (see gotwarlost/istanbul#690)Checklist
main