Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2586] Add user to withPageAuthRequiredProps CSR to match SSR #405

Merged
merged 1 commit into from Jun 1, 2021

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 28, 2021

Description

Add user to withPageAuthRequiredProps CSR to match SSR.

withPageAuthRequired(({ user }) => <div>{ user.name }</div>)

Also fixes the example at https://github.com/auth0/nextjs-auth0/blob/main/EXAMPLES.md#protecting-a-client-side-rendered-csr-page

References

fixes #403

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

@adamjmcgrath adamjmcgrath added the review:small Small review label May 28, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner May 28, 2021 14:32
@vercel
Copy link

vercel bot commented May 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/A4C4CMHJux6drGFbhrQVVvwAvHRR
✅ Preview: Canceled

@adamjmcgrath adamjmcgrath merged commit bba8851 into main Jun 1, 2021
@adamjmcgrath adamjmcgrath deleted the with-page-auth-required-props branch June 1, 2021 09:23
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withPageAuthRequired() not returning a user object
2 participants