[SDK-1756] Remove HTML5 novalidate attribute from Lock form #1890
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
added
CH: Changed
enhancement
|
Build is failing but the fix is in #1889, will rebase once that PR is merged. |
lbalmaceda
previously approved these changes
Jun 30, 2020
lbalmaceda
approved these changes
Jun 30, 2020
Merged
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* [SDK-1756] Remove HTML5 novalidate attribute from Lock form * Update snapshot Co-authored-by: Luciano Balmaceda <balmacedaluciano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change removes the HTML5
novalidateattribute, preventing the browserfrom performing its own native validation and allowing Lock to do its
validation instead.
The native validation prevented users from submitting email addresses such as
"téstiñg.üsêr@example.com", which is a valid value on the Auth0 server side.
References
Raised through internal service desk ticket.
Testing
Tested manually. Cannot test through integration testing as the client-side
native validation does not kick in.
Checklist