Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump pug from 2.0.0-rc.4 to 3.0.2 #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot-preview[bot]
Copy link

Bumps pug from 2.0.0-rc.4 to 3.0.2.

Release notes

Sourced from pug's releases.

pug-code-gen@3.0.2

Bug Fixes

  • Sanitise the pretty option (#3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #3312 for more details.

pug@3.0.2

Bug Fixes

  • Serialize Buffers to strings when storing sources for use with compileDebug: true (#3269)

pug-code-gen@3.0.1

Bug Fixes

  • Update with to resolve core-js deprecation notice (#3259)

pug@3.0.1

Bug Fixes

  • Sanitise the pretty option (#3314)

    If a malicious attacker could control the pretty option, it was possible for them to achieve remote code execution on the server rendering the template. All pug users should upgrade as soon as possible, see #3312 for more details.

pug-runtime@3.0.1

Bug Fixes

  • Properly handle non-string values when rethrowing errors (#3269)

pug-runtime@3.0.0

Breaking Changes

  • Drop support for node 6 and 8 (#3243)

Bug Fixes

  • wrap setting err.message with a try/catch (#2996)

pug-attrs@3.0.0

Breaking Changes

  • Drop support for node 6 and 8 (#3243)

pug-code-gen@3.0.0

Breaking Changes

  • Drop support for node 6 and 8 (#3243)

New Features

... (truncated)

Commits
  • d4b7f60 Properly handle errors originating from included files when compileDebug is e...
  • d6f0615 fix capture groups for "each" statements (#3274)
  • 73ea7cf fix: keep lexer plugins inside tag interpolation (#3296)
  • 29a53c5 fix: Fix pug-lexer parsed escaped interpolations incorrectly (#3299)
  • 60b1b15 chore: update supported versions (#3315)
  • 991e78f fix: sanitise and escape the pretty option (#3314)
  • 06baa52 Fix TypeScript and add eachOf token definition (#3262)
  • 13e46e9 chore: update with (#3259)
  • c077df4 docs: fix rolling versions link
  • ccba7da ci: publish canary release (#3257)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by pug-bot, a new releaser for pug since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [pug](https://github.com/pugjs/pug) from 2.0.0-rc.4 to 3.0.2.
- [Release notes](https://github.com/pugjs/pug/releases)
- [Commits](https://github.com/pugjs/pug/compare/pug@2.0.0-rc.4...pug@3.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview
Copy link
Author

We've just been alerted that this update fixes a security vulnerability:

Sourced from The GitHub Security Advisory Database.

Remote code execution via the pretty option.

Impact

If a remote attacker was able to control the pretty option of the pug compiler, e.g. if you spread a user provided object such as the query parameters of a request into the pug template inputs, it was possible for them to achieve remote code execution on the node.js backend.

Patches

Upgrade to pug@3.0.1 or pug-code-gen@3.0.2 or pug-code-gen@2.0.3, which correctly sanitise the parameter.

Workarounds

If there is no way for un-trusted input to be passed to pug as the pretty option, e.g. if you compile templates in advance before applying user input to them, you do not need to upgrade.

References

Original report: pugjs/pug#3312

For more information

If you believe you have found other vulnerabilities, please DO NOT open an issue. Instead, you can follow the instructions in our Security Policy

Affected versions: ["< 3.0.1"]

@dependabot-preview dependabot-preview bot changed the title Bump pug from 2.0.0-rc.4 to 3.0.2 [Security] Bump pug from 2.0.0-rc.4 to 3.0.2 Mar 3, 2021
@dependabot-preview dependabot-preview bot added the security Pull requests that address a security vulnerability label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants