Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: depend on pytest<8.1.0 #192

Merged
merged 2 commits into from Mar 4, 2024
Merged

TST: depend on pytest<8.1.0 #192

merged 2 commits into from Mar 4, 2024

Conversation

frankenjoe
Copy link
Collaborator

doctestplus is not compatible with pytest==8.1.0, see #190 (comment)

@frankenjoe frankenjoe requested a review from hagenw March 4, 2024 10:23
@hagenw
Copy link
Member

hagenw commented Mar 4, 2024

I reported it upstream at scientific-python/pytest-doctestplus#239.

As we are working in the development branch at the moment, I agree with just pinning the pytest version until doctestplus is fixed.

@hagenw hagenw merged commit 9a4125b into dev Mar 4, 2024
9 checks passed
@hagenw hagenw deleted the pytest<8.1.0 branch March 4, 2024 11:08
@hagenw
Copy link
Member

hagenw commented Mar 4, 2024

As expected, this caused some uproar in the community.

In the meantime, pytest v8.1.0 was yanked (pytest-dev/pytest#12069) and we got a new release of doctestplus (scientific-python/pytest-doctestplus#239 (comment)). I would propose we wait until they repeat the actual pytest v8.1.0 release and do a new pull request then removing the upper limit for pytest.

hagenw pushed a commit that referenced this pull request May 3, 2024
* TST: depend on pytest<8.1.0

* update comment
hagenw pushed a commit that referenced this pull request May 3, 2024
* TST: depend on pytest<8.1.0

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants