Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.7.2 #412

Merged
merged 1 commit into from
May 16, 2024
Merged

Release 1.7.2 #412

merged 1 commit into from
May 16, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented May 16, 2024

image

@hagenw hagenw requested a review from ChristianGeng May 16, 2024 12:35
ChristianGeng
ChristianGeng approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added fix has been previously reviewed.

My intuition tells me that the comma in line 14 would be omitted in English.

This is cosmetics, therefore approving anyway.

@hagenw hagenw merged commit 44df511 into main May 16, 2024
9 checks passed
@hagenw hagenw deleted the release-1.7.2 branch May 16, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianGeng ChristianGeng ChristianGeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hagenw @ChristianGeng