Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Initialize of builders accepts app and env for Sphinx>5.1 #125

Merged
merged 1 commit into from
Aug 1, 2022
Merged

fix: Initialize of builders accepts app and env for Sphinx>5.1 #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
max-parallel: 4
matrix:
python-version: [3.6, 3.7, 3.8, 3.9, '3.10']
sphinx-version: ['>=3.0.0,<4.0.0', '>=4.0.0,<5.0.0', '>=5.0.0,<6.0.0']
sphinx-version: ['>=3.0.0,<4.0.0', '>=4.0.0,<5.0.0', '>=5.0.0,<5.1.0', '>=5.1.0,<6.0.0']
exclude:
# Old major version does not support python 3.10
- python-version: '3.10'
Expand Down
4 changes: 2 additions & 2 deletions sphinx_revealjs/builders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ class RevealjsHTMLBuilder(StandaloneHTMLBuilder):
search = False

def __init__(self, app, env: BuildEnvironment = None): # noqa: D107
# TODO: Remove it if this not need support Sphinx 4.x and older
if sphinx_versoin[0] < 5:
# TODO: Remove it if this not need support Sphinx 5.1.0 and older
if sphinx_versoin[0] <= 4 or sphinx_versoin[:2] == (5, 0):
super().__init__(app)
else:
super().__init__(app, env)
Expand Down