Initialize of builder classes support create_builder for Sphinx 5.x and later #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
env
as optional argument intoRevealjsHTMLBuilder.__init__
for Sphinx 5.x and later.Reason
Sphinx 5.x try passing
app
andenv
when registry create builders.app
only, passingapp
.After Sphinx is 7.x,
craete_builder
raise error if custom builder acceptapp
only.This PR is patch for future.
Why I patch it NOW?
For Sphinx v5.1.0
Sphinx v5.1.0 failure handle in
except
(ref).So,
sphinx-build
is failure by only Sphinx v5.1.0 and sphinx-revealjs <= v2.0.0 .Refs